Skip to content

Conversation

@kirthana14m
Copy link
Collaborator

No description provided.

@emankov emankov changed the title Enable the PSDB on HIPIFY - In progress [HIPIFY][test][infra] Enable the PSDB on HIPIFY - In progress Jan 8, 2026
@emankov emankov added infrastructural related to the Repo infrastructure test Testing is only affected labels Jan 8, 2026
@ranapratap55
Copy link
Collaborator

Could you let us know why is this PR directly on amd-mainline? @kirthana14m

@kirthana14m kirthana14m changed the title [HIPIFY][test][infra] Enable the PSDB on HIPIFY - In progress [HIPIFY][test][infra] Enable Linux rock ci psdb on HIPIFY Jan 13, 2026
@kirthana14m
Copy link
Collaborator Author

Hi @ranapratap55
Currently, PSDB are planned to be enabled on amd-mainline and amd-staging branches

@emankov
Copy link
Collaborator

emankov commented Jan 13, 2026

Hi @ranapratap55 Currently, PSDB are planned to be enabled on amd-mainline and amd-staging branches

So, can we abandon this one in favor of the #2294, which is the same but for amd-staging?

@kirthana14m
Copy link
Collaborator Author

PR#2294 raised has dedicated optimized build and test steps for amd-staging. Therefore, both PR raised are essential.

@skganesan008
Copy link
Collaborator

skganesan008 commented Jan 13, 2026

  • Please change the commit message from [HIPIFY][test][infra] Enable Linux rock ci psdb on HIPIFY
    to something like "Enable Linux rock ci psdb". The prefix [HIPIFY][test][infra] and suffix HIPIFY is not needed as we are on that repo and PSDB points to an infra change. Thinking more about, [infra] prefix is not a bad idea to leave it in place.

@skganesan008
Copy link
Collaborator

Evgeny, jfyi, the number of yaml files can be expected to be reduced in the near future as there are some additional optimization work that is currently ongoing.

@kirthana14m kirthana14m changed the title [HIPIFY][test][infra] Enable Linux rock ci psdb on HIPIFY [HIPIFY][test][infra] Enable Linux rock ci psdb Jan 13, 2026
@emankov
Copy link
Collaborator

emankov commented Jan 13, 2026

  • Please change the commit message from [HIPIFY][test][infra] Enable Linux rock ci psdb on HIPIFY
    to something like "Enable Linux rock ci psdb". The prefix [HIPIFY][test][infra] and suffix HIPIFY is not needed as we are on that repo and PSDB points to an infra change. Thinking more about, [infra] prefix is not a bad idea to leave it in place.

Please keep the suffixes for all HIPIFY PRs and commits, as we are going to upstream the HIPIFY tools to LLVM.

@emankov emankov changed the title [HIPIFY][test][infra] Enable Linux rock ci psdb [HIPIFY][test][infra] Enable Linux Rock CI PSDB for amd-mainline Jan 13, 2026
Copy link
Collaborator

@skganesan008 skganesan008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the change from ROCm/llvm-project#1087 as well to address a manifest update change in this repo and on spirv

@kirthana14m
Copy link
Collaborator Author

Please include the change from ROCm/llvm-project#1087 as well to address a manifest update change in this repo and on spirv

The suggested changes are added to this repo and spirv

@kirthana14m kirthana14m merged commit 15bcb23 into amd-mainline Jan 14, 2026
42 checks passed
@kirthana14m kirthana14m deleted the amd/dev/kirthana14m/hipify-psdb-ci-trigger branch January 14, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructural related to the Repo infrastructure test Testing is only affected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants